ColossalAI icon indicating copy to clipboard operation
ColossalAI copied to clipboard

[autoparallel] Patch meta information of `torch.tanh()` and `torch.nn.Dropout`

Open Cypher30 opened this issue 2 years ago • 3 comments

📌 Checklist before creating the PR

  • [x] I have created an issue for this PR for traceability
  • [x] The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • [x] I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234 Resolved #2630 Resolved #2631

📝 What does this PR do?

Summarize your work here. if you have any plots/diagrams/screenshots/tables, please attach them here.

In this PR, I patch meta information of torch.tanh() and torch.nn.Dropout. I also modify all the meta information generators in auto_parallel/meta_profiler/meta_registry/activation.py and turn them into the same template so that we have cleaner code. We could think about refactoring more code in meta_registry in the future.

Again, the test is not supported on torch 1.11.0, so I attach the results here Screenshot 2023-02-16 at 22 10 30

💥 Checklist before requesting a review

  • [x] I have linked my PR to an issue (instruction)
  • [x] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • [x] I have performed a self-review of my code
  • [x] I have added thorough tests.
  • [x] I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • [x] 🌝 Yes, I do.
  • [ ] 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

Cypher30 avatar Feb 16 '23 14:02 Cypher30

The code coverage for the changed files is 45%.

Click me to view the complete report
Name                                                                                   Stmts   Miss  Cover
----------------------------------------------------------------------------------------------------------
colossalai/auto_parallel/meta_profiler/meta_registry/activation.py                        29     15    48%
tests/test_auto_parallel/test_tensor_shard/test_metainfo/test_activation_metainfo.py      44     25    43%
----------------------------------------------------------------------------------------------------------
TOTAL                                                                                     73     40    45%

github-actions[bot] avatar Feb 16 '23 14:02 github-actions[bot]

The code coverage for the changed files is 45%.

Click me to view the complete report
Name                                                                                   Stmts   Miss  Cover
----------------------------------------------------------------------------------------------------------
colossalai/auto_parallel/meta_profiler/meta_registry/activation.py                        29     15    48%
tests/test_auto_parallel/test_tensor_shard/test_metainfo/test_activation_metainfo.py      44     25    43%
----------------------------------------------------------------------------------------------------------
TOTAL                                                                                     73     40    45%

github-actions[bot] avatar Feb 16 '23 15:02 github-actions[bot]

The code coverage for the changed files is 44%.

Click me to view the complete report
Name                                                                                   Stmts   Miss  Cover
----------------------------------------------------------------------------------------------------------
colossalai/auto_parallel/meta_profiler/meta_registry/activation.py                        28     15    46%
tests/test_auto_parallel/test_tensor_shard/test_metainfo/test_activation_metainfo.py      44     25    43%
----------------------------------------------------------------------------------------------------------
TOTAL                                                                                     72     40    44%

github-actions[bot] avatar Feb 16 '23 15:02 github-actions[bot]