ColossalAI icon indicating copy to clipboard operation
ColossalAI copied to clipboard

[nn/parallel/data_parallel.py]: Rename "_pre_bacward" method of ZeroDDP to "_pre_backward"

Open junxu opened this issue 2 years ago • 3 comments

📌 Checklist before creating the PR

  • [ ] I have created an issue for this PR for traceability
  • [x] The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • [ ] I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Rename "_pre_bacward" method of ZeroDDP to "_pre_backward".

💥 Checklist before requesting a review

  • [ ] I have linked my PR to an issue (instruction)
  • [ ] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • [ ] I have performed a self-review of my code
  • [ ] I have added thorough tests.
  • [ ] I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • [x] 🌝 Yes, I do.
  • [ ] 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

junxu avatar Feb 14 '23 09:02 junxu

LGTM. Will merge when checks are passed.

FrankLeeeee avatar Feb 15 '23 01:02 FrankLeeeee

Hi, seems some Github updates broke our CI checks. I have fixed the CI and can you rebase your code with the latest code so that the correct CI can be triggered?

FrankLeeeee avatar Feb 15 '23 02:02 FrankLeeeee

The code coverage for the changed files is 78%.

Click me to view the complete report
Name                                      Stmts   Miss  Cover
-------------------------------------------------------------
colossalai/nn/parallel/data_parallel.py     386     85    78%
-------------------------------------------------------------
TOTAL                                       386     85    78%

github-actions[bot] avatar Feb 16 '23 02:02 github-actions[bot]