samurai
samurai copied to clipboard
feat: [WIP] support [email protected] headers
This is a WIP.
Description
Adaption to the new tree xtensor folder structure. TODO : add conditional macros to support older xtensor versions
Code of Conduct
By submitting this PR, you agree to follow our Code of Conduct
- [x] I agree to follow this project's Code of Conduct
At this point, I have to
- solve the HighFive xtensor issue (mpi-mamba)
- solve the cppcheck issue (it enforces me to always use the old include path even if it uses [email protected]
- ensure compatibility for all demos
The H5 error comes from :
#ifdef XTENSOR_VERSION_MAJOR
#ifndef H5_USE_XTENSOR
#define H5_USE_XTENSOR
#endif
#endif
#ifdef H5_USE_XTENSOR
#include <xtensor/xarray.hpp>
#include <xtensor/xtensor.hpp>
#include "xtensor.hpp"
#endif
That always includes xtensor headers in HighFive in our project.
I sould try to override the value XTENSOR_VERSION_MAJOR