stravalib icon indicating copy to clipboard operation
stravalib copied to clipboard

Adding test for naive_datetime in case value is none

Open lwasser opened this issue 1 year ago • 1 comments

closes #issue-this-closes-here

i am playing with tests - this is just a draft as i get to know the test suite right now.

Description

Type of change

Select the statement best describes this pull request.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update
  • [ ] This is a documentation update
  • [ ] Other (please describe)

Does your PR include tests

If you are fixing a bug or adding a feature, we appreciate (but do not require) tests to support whatever fix of feature you're implementing.

  • [ ] Yes
  • [ ] No, i'd like some help with tests
  • [ ] This change doesn't require tests

Did you include your contribution to the change log?

  • [ ] Yes, changelog.md is up-to-date.

If you are having a hard time getting the tests to run correctly feel free to ping one of the maintainers here!

lwasser avatar Aug 11 '23 16:08 lwasser

Codecov Report

Merging #402 (ea7fcf1) into master (b24415c) will increase coverage by 0.11%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   87.64%   87.76%   +0.11%     
==========================================
  Files          10       10              
  Lines        1668     1668              
  Branches      148      148              
==========================================
+ Hits         1462     1464       +2     
+ Misses        167      166       -1     
+ Partials       39       38       -1     

see 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 11 '23 17:08 codecov[bot]