stravalib icon indicating copy to clipboard operation
stravalib copied to clipboard

Published 20 hours ago • verified publisher icon hozn

META: check client methods vs. Strava API consistency

Open jsamoocha opened this issue 2 years ago • 1 comments

Methods from the client module can have one of the following states compared with the Strava API:

  1. Officially documented
  2. Officially deprecated
  3. Undocumented but somehow working
  4. Undocumented and unsupported (returning 4XX responses)

We need to systematically check the methods in client, and for states 2/3/4, we need to investigate possible solutions and create new issues where necessary.

jsamoocha avatar Jan 24 '23 14:01 jsamoocha

Issue #238 has an example of a method removed from the Strava API but still in the library

futureshape avatar Feb 27 '23 10:02 futureshape

@jsamoocha is there anything left todo on this task? i think the one issue around checking undocumented attributes is a good one for us to implement! But i think we've gone through most if not all of the API endpoints at this point to check for what's documented and what's returned.

Can we close this? ✨

lwasser avatar Jul 19 '24 22:07 lwasser

Given our limited availability, it may be better to deal with inconsistencies between Strava API and our client methods on a case-by-case basis (i.e., when a user reports something is broken or doesn't work as expected), instead of the proactive approach suggested in this issue. Closing this now.

jsamoocha avatar Jul 20 '24 06:07 jsamoocha