stravalib icon indicating copy to clipboard operation
stravalib copied to clipboard

Add an option to mute Strava activity on update

Open ollyajoke opened this issue 3 years ago • 4 comments

Recently Strava has introduced an option to "mute" an activity (hide it from Home and Club feeds, but keep visible on athlete's profile). From inspecting the activity structure, this bool activity setting is called hide_from_home. It has been available to all Strava users since September but, unfortunately, has not yet been documented on Strava's API page.

ollyajoke avatar Oct 25 '21 01:10 ollyajoke

LGTM

yihong0618 avatar Oct 25 '21 01:10 yihong0618

hey @ollyajoke !! thank you so much for this pr. i'm trying to help a bit with this package and wondered - is this documented in the strava API docs yet? would be great to reference it here if so. what is hard with these pr's is not having an automated test suite setup here yet. i won't be able to test things for a little bit locally but this seems like a really good enhancement to the code base. many thanks in advance and again thank you for submitting this.

lwasser avatar Apr 18 '22 22:04 lwasser

hi @lwasser - yes, it's already on their docs! Here it is mentioned in their changelog as of October 26, 2021. And I can see the hide_from_home boolean field is listed as part of the DetailedActivity and UpdatableActivity objects.

ollyajoke avatar Apr 28 '22 04:04 ollyajoke

Is there any plan for when this might get merged?

twillmott avatar May 18 '22 20:05 twillmott

hi everyone @twillmott @ollyajoke we are in the middle of a big overhaul of stravalib and have a push to pypi planned actually in the next day. I am going to merge this PR as it has an approval already. Apologies for the delay. once we get this push to pypi we will be on a much more frequent maintenance pattern.

lwasser avatar Nov 22 '22 00:11 lwasser

Thank you for the contribution @ollyajoke !!! you rock! 🚀

lwasser avatar Nov 22 '22 00:11 lwasser