stravalib icon indicating copy to clipboard operation
stravalib copied to clipboard

RateLimitExceeded raised with wrong parameters

Open sander48k opened this issue 6 years ago • 1 comments

When the RateLimitExceeded exception is raised, its limit and timeout parameters seem to be swapped. E.g. limit = 900, timeout = 600 when the short limit of the DefaultRateLimiter has exceeded.

I think, in XRateLimitRule._check_limit_rates, _raise_rate_limit_exception is called with parameters in the wrong order.

sander48k avatar May 31 '18 07:05 sander48k

Thanks for posting this; I'll take a look!

hozn avatar May 31 '18 15:05 hozn

closing this as it was addressed here given stravalib's recent updates! https://github.com/stravalib/stravalib/pull/446

lwasser avatar Jan 17 '24 02:01 lwasser