vmtouch icon indicating copy to clipboard operation
vmtouch copied to clipboard

Please add -w wait until all pages are locked to manual

Open tycho-kirchner opened this issue 5 years ago • 2 comments

Hi, and thanks for this tool (: The important option -w misses in the manual and is only displayed when issuing --help. This is confusing. After all, in daemon mode intuitively I expected a non-zero exit code on error, which is only the case, if -w is passed. I think this should be changed, if a user is not interested in the return value, he could simply launch vmtouch async using the ampersand &.

Thanks Tycho

tycho-kirchner avatar Dec 10 '20 14:12 tycho-kirchner

I agree on all counts. In fact, I would like to make -d imply -w if possible. Are there any backwards-compatibility problems if we do that?

About adding -w to the manual, can you please send in a pull request? Thank you!

hoytech avatar Dec 10 '20 14:12 hoytech

Being left out of the manpage means I've only now discovered the -w option. I had a script for launching discrete vmtouch -dL instances that relied on -w being absent; each vmtouch process would read from a different physical HDD so they could all run concurrently.

If I understand correctly, making -d imply -w would make my vmtouch invocations run sequentially instead of simultaneously. I'm not against the change, in fact I've already updated my script to use -dwL, just pointing out a possible scenario where it matters.

EDIT: if backwards-compatibility is a concern, maybe add a new -D option equivalent to -d -w instead?

cy7yz2rj avatar Dec 12 '20 15:12 cy7yz2rj