hoytech
Removed goto statements
Is there any specific reason to keep the goto statements in the code? I have tried to remove those statements with minimal changes.
Thanks for the patch. You're right there's no great reason to prefer goto here since both these instances are essentially loops. However, IMO it's somewhat nice that the destinations have readable labels such as retry_open and bail, and these are removed in this patch.
I'll consider this for the next release, thanks!
Thank you. On Jul 10, 2016 7:45 PM, "Doug Hoyte" [email protected] wrote:
Thanks for the patch. You're right there's no great reason to prefer goto here since both these instances are essentially loops. However, IMO it's somewhat nice that the destinations have readable labels such as retry_open and bail, and these are removed in this patch.
I'll consider this for the next release, thanks!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hoytech/vmtouch/pull/36#issuecomment-231591208, or mute the thread https://github.com/notifications/unsubscribe/ACEcbzLc2z-ILlmvX41eW3shxTP0NV2cks5qUP5zgaJpZM4JDvnQ .
Oops, I can't merge this patch because of conflicts caused in another branch I merged in. I'm going to leave this out for the next release, maybe we can get to it in some code clean-up I'm planning later.
Yeah sure.
On Tue, Aug 9, 2016 at 12:44 AM, Doug Hoyte [email protected] wrote:
Oops, I can't merge this patch because of conflicts caused in another branch I merged in. I'm going to leave this out for the next release, maybe we can get to it in some code clean-up I'm planning alter.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hoytech/vmtouch/pull/36#issuecomment-238345437, or mute the thread https://github.com/notifications/unsubscribe-auth/ACEcbzZapdBNA1ACKU3NJlDnYeVIOoJeks5qd4AWgaJpZM4JDvnQ .
Abijith KP github.com/abijith-kp abijithkp.me