botkit-storage-redis icon indicating copy to clipboard operation
botkit-storage-redis copied to clipboard

Published 20 hours ago • verified publisher icon howdyai

Be consistent with BotKit api

Open imjul1an opened this issue 7 years ago • 0 comments

By default, BotKit implements delete on local storage.users object https://github.com/howdyai/botkit/blob/master/lib/storage/simple_storage.js#L73

Botkit-starage-redis has a different implementation, https://github.com/howdyai/botkit-storage-redis/blob/master/src/index.js#L51. Instead of delete we have remove.

A proposal is to rename the remove function to delete function. But, in your case, it would make more sense to support both remove and delete for backward compatibility.

So it would be nice to keep an API consistent with the BotKit.

imjul1an avatar Feb 19 '18 16:02 imjul1an