botkit-starter-slack icon indicating copy to clipboard operation
botkit-starter-slack copied to clipboard

Published 20 hours ago • verified publisher icon howdyai

Fixed .env include

Open ghostffcode opened this issue 7 years ago • 2 comments

This takes care of the security issue I mentioned in issue #8. Hosting services like heroku and AWS have already made provision for environmental configurations. Which is a lot more secure and gives little room for accidentally sharing sensitive informations. I believe it is best to leave .env config file to development environment only.

ghostffcode avatar Apr 05 '17 22:04 ghostffcode

I agree that changes to .env should be excluded from future Git commits, thanks!

I'm not sure about the production test -- is this common practice?

benbrown avatar Apr 06 '17 02:04 benbrown

Yes, it is.

Test environments have there own ways of handling environment variables. For instance, in travis here is a detail explanation on including env configurations: https://docs.travis-ci.com/user/environment-variables/

ghostffcode avatar Apr 06 '17 02:04 ghostffcode