Howard Wu
Howard Wu
I see your point here, let me think about it. While the drop in height isn't great, it is frankly the correct behavior. We should be optimizing for higher quality...
I'm a big fan of the `handshake_inner` abstraction here. Thank you for decoupling it, very nice approach to handing `connecting_peers`. It is elegant and straightforward.
I made one logical change from the original PR change. Before this PR, we always called `ensure_peer_is_allowed`. This PR made the call to `ensure_peer_is_allowed` only when `ConnectionSide::Initiator`. I changed it...
Sorry, I just realized CI was not checking the `tcp` crate, and as this PR modifies it, I have added it in here. For those reading this, I have previously...
Amazing catch!
Closing as this issue has been resolved. Private keys can now be provided via a file.
Thanks Dylan for reporting this, it looks like we need to bump this up. If anyone is open to bumping versions and updating interfaces, I'd be happy to take a...
@Pratyush @vicsn i think it might be time for us to debug this (along with AleoHQ/snarkVM#986) after multi-executions are feature complete. this issue seems to reappear from time to time...
@mdelle1 can you address this PR's issues?
To share additional context on this topic: For context, during the ZKSecurity audit of the BFT, the priority was `safety over liveness`. When turning off a node, your mempool is...