John Howard

Results 1682 comments of John Howard

`209 runs so far, 0 failures (100.00% pass rate). 3.10638293s avg, 3.939583567s max, 1.017441112s min`

Consider using Drop for `release` to prevent any ability to miss it

internalTrafficPolicy: done https://github.com/istio/ztunnel/pull/868 clusterIP, ports: done sessionAffinity: https://github.com/istio/ztunnel/issues/450, TODO externalName: nothing needed externalIPs: I think nothing needed? So we are in pretty good shape. sessionAffinity is rarely used so I...

Do you have a strong use case for this? I worry the complexity of this outweighs the benefits, at least for the next 6 months or so while we are...

AFAIK the only remaining is https://github.com/istio/ztunnel/issues/450

I think this is mostly done and just 1 final task tracked in https://github.com/istio/ztunnel/issues/1191

My concern is not with the crate it's with the concept in general

Just thought of this case: what about a ServiceEntry w/ selector... is it always global? We don't have the backwards compat issues with it since its pure Istio, but its...

I don't feel great about making `name.namespace.svc` different from `name.ns.svc.cluster.local`. Conceptually it is sound, I worry it will break many assumptions users have made in k8s though? I supposed if...

I am against MESH_INTERNAL personally. Its confusing because "cluster local" vs "full mesh" is orthogonal to "mesh" vs "not mesh". So we are giving a new meaning to an existing...