John Howard

Results 1682 comments of John Howard

There is a new field, gateway.spec.infrastructure, for these _types_ of things. But it hasn't been fleshed out; I had a proposal to add quite a bit of functionality there but...

the integration tests already have a delta xds workload for a couple years On Wed, Dec 20, 2023, 8:02 PM Zhonghu Xu ***@***.***> wrote: > ***@***.**** requested changes on this...

AFAIK it is enabled for all the tests? We run almost all of the tests in "workload agnostic" mode which means they run in all the combinations of workload types....

> BTW if we turn on delta xds, how can we test non delta path. We already test delta + non-delta today; some workloads use delta. With this PR, we...

Not stale, ECDS is fixed

@hzxuzhonghu ptal, this is now passing all tests

IMO we shouldn't skip it either. Its just a bad implementation in the SPIRE-Istio support to assume to use the same SDS for everything

There are already 2 SDS paths in Istio. the local UDS (for workload cert and files) and remote Istiod XDS (over ADS) for credentialName. So really this is probably looking...

How can you have an expectation that every pod in the entire cluster has the same definitions for metrics? That seems like an invalid expectation.