John Howard comments

Results 1679 comments of


                                            John Howard

test: fix CNI Version Skew test

@bleggett mind reviewing? postsubmit is broken without this

Sidecar CRD is ignored when pod rebalance from one Istiod to another and is endpoint in a ServiceEnrty

Can you maybe post the SE and Sidecar or an example? Does it happen every time? If you want to trigger it more (or less)often for testing, the --keepaliveMaxServerConnectionAge flag...

Delete HTTPRoute will trigger two push event loops, is this expected?

it's because it triggers a gateway status change. Probably could be optimized to not push on status change (or, at least, that field in status)

Delete HTTPRoute will trigger two push event loops, is this expected?

The thing that is tricky is we use pushes to trigger recomputing GW API resources. So while we don't use status at all for XDS generation, if we were to...

Delete HTTPRoute will trigger two push event loops, is this expected?

Yeah but the part that writes the status and the part that reads the events doesn't really know _who_ wrote it which makes it challenging. In Gateway API most objects...

Convert citadel cert expiry timestamp metrics to citadel cert expiry time left

We already have one in agent so we should make sure we have a consistent name/semantics there

Test framework: remove "Static VM" concept

/test all

Test framework: remove "Static VM" concept

> does the readme need to be updated? I don't know any readme that references this?

Test framework: remove "Static VM" concept

@istio/wg-test-and-release-maintainers LFR

v1.22.0 ambient inject iptables rules in pod failed for CentOS 7

I think you need xt_connmark https://istio.io/latest/docs/setup/platform-setup/prerequisites/#kernel-module-requirements-on-cluster-nodes. Note that doc will need to be updated to say it's needed for ambient as well