John Howard

Results 1677 comments of John Howard

with PILOT_SEND_UNHEALTHY_ENDPOINTS that is no longer 100 valid, but that is not enabled by default.

> > The intent behind this is that without outlierDetection, we cannot detect failing workloads, so will never failover at all. IE its not "failover" just "only send to same...

For now the only way is `outlierDetection: {}`. I cannot promise 100%, but I would imagine this will not likely go away even if it was unintended originally.

What is your intended behavior? Traffic *never* leaves the zone? "Failover" without an ability to ever failover (due to missing unhealthy concept) seems unexpected. Distribute has no "failover" concept so...

If you don't want to failover at all we should probably have a new concept. Strawman: ```yaml failoverPriority: [region, zone] failoverToGlobal: false ``` Behavior without failoverToGlobal (or failoverToGlobal=true): match same...

If you never send "unhealthy" in any way, setting priorities is useless; you should just skip any non-zero priority since they will never be used. Hence my comment in https://github.com/istio/istio/issues/48084#issuecomment-1832576714

If we look at https://gcsweb.istio.io/gcs/istio-prow/pr-logs/pull/istio_istio/48301/integ-ambient_istio/1742556718845399040/artifacts/ambient-4a67fe238d7346db8754f38/TestTraffic/dns/tproxy/tcp_localhost_server/_test_context/echo-1-28253-state4267053168/primary-0/, we see the dump is broken. We have the ambient AND normal workloads all in one namespace. But because we set them up separately, we...

@yuval-k we could have `PILOT_NODE_UNTAINT_CONTROLLERS_NAMESPACE=...`. Unset=disabled, set sets the namespace. Then its one config value. In the rbac we can check the env var too probably? I would prefer to...

Why not just set it in MeshConfig? https://github.com/istio/istio/blob/388d5d1b9f37e7c3d15cf72967fad22f0b8e70fb/pilot/pkg/networking/core/v1alpha3/cluster_builder.go#L495 it is respected

> force cache syncs at regular intervals We don't do the "relisting" thing that other projects do. The sync happens once at startup. The key is to let all the...