John Howard

Results 1676 comments of John Howard

This has been updated at some point to include this

https://github.com/istio/api/issues/3127

Similar use case is things like "give priority to local endpoints _within_ a service" (where local could be node, region, zone, cluster, mesh, network, or arbitrary things). Perhaps that is...

Another alternative is to make a non-Service backend that represents some "Composite" backend. Which could be implementation specific or not. Related: https://github.com/kubernetes-sigs/gateway-api/discussions/1764

Hmm: https://github.com/istio/istio/blob/febeb83b345abdf32ee0dc7551bd3605dbce2482/pkg/bootstrap/platform/gcp.go#L98-L102 I wonder why its looking for cluster-location than falling back to Zone(). I would think Zone() is the correct one? These translate to `instance/zone` and `instance/attributes/cluster-location` btw

Interesting: https://github.com/googleapis/google-cloud-go/pull/9094. So some other places are intentionally doing this. I think in some instances we may want one vs the other, but we have a single field used for...

Ah nvm, the config_dump zone is a fallback, not the primary source: https://github.com/istio/istio/blob/b6cfe7ec72d321d51aa0f66cdd0b9a0cf7865e5b/pilot/pkg/xds/ads.go#L618. So locality LB should be fine in this case

Maybe @kyessenov or @lei-tang can help out