John Howard
John Howard
/ok-to-test Added hold to allow the feature own @therealmitchconnors to look as well
This is a limitation of prometheus and shouldn't be impacted by Istio, unless I am missing something..?
/retest-required
/retest known flake, I have a fix in another PR
`istio: ingressgateway` is just a label selector, not a magic constant. Just like you would expect every Kubernetes Service yaml to have the same labels, IMO it's the same here....
For testing: we have ServiceEntry testing already via https://github.com/istio/istio/blob/b524d9836880a88c7aaa91956dfca24c82c29039/pkg/test/framework/components/echo/common/deployment/external.go#L33. We can/should improve this for IPv6 as needed. We already run an IPv6 cluster in presubmit, and have logic to skip...
Take a look at https://istio.io/latest/docs/ops/integrations/prometheus/ if you haven't already. We are working on a more long term fix for this but its a ways off (https://docs.google.com/document/d/1NAccj8WyjBXOUsMdOHW9sWW6PeCnrIWpc3muBHd4Cs8/edit#heading=h.xw1gqgyqs5b)
Seems a bit tricky. We don't do this for other types - any other config can be invalid as well. We also don't know if it's invalid or not until...
cc @douglas-reid I think this would need proxy side support
Can we reuse the existing failover in Destination Rule instead of creating a new mechanism?