John Howard
John Howard
^ was for dynamic flags. If we want specifically a "panic mode" then that should be something that is configured to automatically apply IMO (at some threshold, etc); not a...
/test benchmark
There is a integ tests with a cluster running dual stack, but everything running inthe cluster is single stack so I don't think we actually have any tests coverage?
Benchmarks show some troubling results: https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/40634/benchmark_istio/1572678114784317440 maybe due to adding ipDiscovery call? Might be worth breaking that out so we can analyze the main PR in isolation.
> It seems that the job is passed, I think ipDiscovery should be called once the proxy node is created and it should be required in later. Its a benchmark,...
No, look at the logs. It shows a diff for each benchmark On Thu, Sep 22, 2022 at 9:19 AM Steve Zhang ***@***.***> wrote: > It seems that the job...
The `kb/msg` metric is concerning: ``` name old kb/msg new kb/msg delta pkg:istio.io/istio/pilot/pkg/xds goos:linux goarch:amd64 RouteGeneration/gateways-8 1.16k ± 0% 1.16k ± 0% ~ (all equal) RouteGeneration/gateways-shared-8 5.37k ± 0% 5.37k...
Probably. Will take a look... I am not sure what the optimal behavior here is.