John Howard

Results 1676 comments of John Howard

Seems like 10% of CPU time (ie not including `docker run` time) is spent on `reflect.DeepEqual` on `spec.Schema`, always comapring it to `spec.Schema{}`. Maybe a smarter IsEmpty could improve this

[profile.tar.gz](https://github.com/GoogleContainerTools/kpt/files/7043845/profile.tar.gz) profile of set-namespace running. 37% (0.5s) on IsCertainlyClusterScoped is suspicious. I don't even think we actually use the result of that function...

Dropping IsCertainlyClusterScoped cuts execution time from 2.3s to 0.7s. Big improvement! But we do use it in GetMatchingResourcesByCurrentId for resid.ResId.Equals. Seems like something we could improve though. If we really...

Envoy supports it for HTTP Host headers, but the API you are changing here impacts SNI where its not supported: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/listener/v3/listener_components.proto#config-listener-v3-filterchainmatch

> I'm not deep enough in the envoy code to be sure, but from a superficial look at the code I can't see any validation that treats the SNI as...

I definitely do not think we should write supported features to individual objects. TBH I am opposed to putting documentation on CRDs at all, so do not think SupportedFeatures should...

Along with the file exporter is the file receiver: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/filereceiver. I haven't tried it myself but my understanding is this would allow exporting to a file, then later reading with...

I cannot reproduce it _working_ on 1.22.5. I wouldn't expect it to work, either. Maybe you can give a more complete reproduction? I would expect it to only resolve to...

> excludeIPRanges: 10.51.160.0/19,10.51.128.0/19 DNS server is 10.51.192.10. I am almost certain this is the same as https://github.com/istio/istio/issues/53949. Basically now the UDP respects the excludes

On the meantime, the change that causes this was setting `privileged: false` on the daemonset - you can change it to `true` (matching 1.23 settings) to fix this. We will...