John Howard comments

Results 1677 comments of


                                            John Howard

Fix sending to external service entry from a VS

/test all

Fix sending to external service entry from a VS

cc @istio/wg-networking-maintainers

Deprecate `EnableDualStack`

I agree directional but just to be clear, the purpose of the flag is to guard users from unsafe code. Our support for dual stack was very broken recently (https://github.com/istio/istio/pull/51279)...

iptables: test real world roundtrip of iptables rules

/retest

iptables: test real world roundtrip of iptables rules

/retest

iptables: test real world roundtrip of iptables rules

/retest

Istio proxy sidecar startup probe fails when ClusterIP address/port and address/port in service entry with multiple addresses overlap

Thanks for the issue. I can reproduce this on the master branch as well and think I know the root cause..

Istio proxy sidecar startup probe fails when ClusterIP address/port and address/port in service entry with multiple addresses overlap

We need something like this https://github.com/istio/istio/pull/52862 to not key on only the 'primary' IP. I think that Pr needs a few tweaks (and testing) though, just a rough idea

Istio proxy sidecar startup probe fails when ClusterIP address/port and address/port in service entry with multiple addresses overlap

@thorweijie I can confirm this was **not** fixed as you said. I will take a look into this next week

Istio proxy sidecar startup probe fails when ClusterIP address/port and address/port in service entry with multiple addresses overlap

@yelinaung I am pretty sure this is working fine on latest 1.22 and 1.23 and is only broken on master and 1.24. https://github.com/istio/istio/pull/54207 should fix those