watchparty icon indicating copy to clipboard operation
watchparty copied to clipboard

Draggable and resizable chat overlay in full screen mode

Open Argn0 opened this issue 1 year ago • 4 comments

Argn0 avatar May 05 '23 18:05 Argn0

This is pretty cool! Will review the code later, but tested it quickly on the deploy preview.

Quick comments:

  • I'd probably put the reset button as part of the overlay rather than an option in settings
  • Seems like I can't put the box anywhere without covering up the video partially, but idk if anything can be done about that
  • Maybe we should include the tabs so the user can also display video chat if they want?
  • In another issue I think I requested the ability to show both text and video chats at the same time--wondering if it makes sense to make that part of this feature since there's more real estate. But also maybe just a "de-tab" option that expands the right panel would be easier

howardchung avatar May 06 '23 02:05 howardchung

I'd probably put the reset button as part of the overlay rather than an option in settings

I've put the reset button in the settings in case the overlay is somehow "lost" and inaccessible. For example, if the user changes their monitor configuration or screen resolution.

Seems like I can't put the box anywhere without covering up the video partially, but idk if anything can be done about that

We could add a collapse button that collapses the overlay into a tiny box that expands when you click on it.

Maybe we should include the tabs so the user can also display video chat if they want?

This should be possible.

Argn0 avatar May 06 '23 14:05 Argn0

  • made the overlay collapsible
  • now it displays the entire right bar

Argn0 avatar May 06 '23 21:05 Argn0

I may revisit some of this code to try implementing #848 which is asking for something like this but I think for the video chat only (not the text chat).

howardchung avatar Mar 17 '24 09:03 howardchung