stretchly
stretchly copied to clipboard
Published
20 hours ago •
hovancik
hovancik
[Bug]: Closing long break that isn't intentionally triggered causes crash
Version
- [X] I'm using version 1.10.0
Known issues
- [X] I've checked Known issues
Existing issues
- [X] I've checked Existing issues
What operating system are you using?
Windows
Operating System Version
Windows 10 Pro 21H2
Reproduction steps
- have 2+ monitors attached to computer with stretchly
- when long break happens immediately (within 1-2 seconds) press ctrl+x to close
- stretchly crashes with report bug alert window
**Reproduces how often: 100% [What percentage of the time does it reproduce?]
Expected Behavior
No crashing should happen
Actual Behavior
It crashes
Relevant log output
[2022-06-12 21:43:32.488] [info] Stretchly: starting Long Break
[2022-06-12 21:43:34.405] [info] Stretchly: showing window 5 of 8
[2022-06-12 21:43:34.411] [info] Stretchly: showing window 2 of 8
[2022-06-12 21:43:34.438] [info] Stretchly: showing window 3 of 8
[2022-06-12 21:43:35.387] [info] Stretchly: showing window 4 of 8
[2022-06-12 21:43:35.707] [info] Stretchly: postponing Long Break
[2022-06-12 21:43:35.720] [info] Stretchly: showing window 6 of 8
[2022-06-12 21:43:35.788] [error] TypeError: Cannot read properties of null (reading 'center')
at Timeout._onTimeout (C:\Users\\AppData\Local\Programs\Stretchly\resources\app.asar\main.js:878:25)
at listOnTimeout (node:internal/timers:557:17)
at processTimers (node:internal/timers:500:7)
Preferences
{
"microbreakDuration": 20000,
"microbreakInterval": 600000,
"breakDuration": 60000,
"breakInterval": 1,
"breakNotification": false,
"microbreakNotification": true,
"breakNotificationInterval": 30000,
"microbreakNotificationInterval": 10000,
"microbreak": false,
"break": true,
"microbreakStrictMode": false,
"breakStrictMode": false,
"morningHour": 6,
"microbreakPostpone": true,
"breakPostpone": true,
"microbreakPostponeTime": 120000,
"breakPostponeTime": 300000,
"microbreakPostponesLimit": 1,
"microbreakPostponableDurationPercent": 30,
"breakPostponesLimit": 1,
"breakPostponableDurationPercent": 30,
"mainColor": "#1D1F21",
"transparentMode": false,
"opacity": 0.9,
"audio": "crystal-glass",
"volume": 1,
"fullscreen": false,
"ideas": true,
"naturalBreaks": true,
"naturalBreaksInactivityResetTime": 300000,
"allScreens": true,
"useIdeasFromSettings": false,
"language": "en",
"notifyNewVersion": true,
"isFirstRun": false,
"posLatitude": 0,
"posLongitude": 0,
"useMonochromeTrayIcon": false,
"useMonochromeInvertedTrayIcon": false,
"silentNotifications": true,
"monitorDnd": true,
"microbreakStartSoundPlaying": false,
"breakStartSoundPlaying": false,
"themeSource": "system",
"endBreakShortcut": "CmdOrCtrl+X",
"breakWindowWidth": 0.85,
"breakWindowHeight": 0.85,
"checkNewVersion": true,
"breakIdeas": [
{
"data": [
"Not alone",
"Do you find it hard to take a break alone? Try to do it with a co-worker. Aside from making it easier to stick to breaks, you will have a chance to get to know them better. Taking breaks together increases productivity."
],
"enabled": true
},
{
"data": [
"Step away",
"Do you ever notice how your brain can figure things out by itself? All it takes is to step away from the computer and take a break to think about something totally unrelated."
],
"enabled": true
},
{
"data": [
"Microbreaks",
"Rest is a key component in ensuring the performance of the musculoskeletal system. Frequent breaks can decrease the duration of a task and help lower the exposure to ergonomic injury risk."
],
"enabled": true
},
{
"data": [
"Meditation",
"Research studies suggest that mindfulness-based exercises help decrease anxiety, depression, stress, and pain, and help improve general health, mental health, and quality of life. Not sure how to start? There are numerous apps to help you out."
],
"enabled": true
},
{
"data": [
"Blink",
"Looking at screens for a long time causes you to blink less, thus exposing your eyes to the air. Blink rapidly for a few seconds to refresh the tear film and clear dust from the eye surface."
],
"enabled": true
},
{
"data": [
"Ergonomics",
"Improper height and angle of the keyboard, mouse, monitor or working surface can cause health problems. Take some time to read about desk ergonomics."
],
"enabled": true
},
{
"data": [
"Move",
"There are a lot of ways you can exercise within your office. Try marching in place or doing desk push-ups."
],
"enabled": true
},
{
"data": [
"Change",
"Do you have a stability ball or standing work desk? Consider replacing your desk chair with them for a while."
],
"enabled": true
},
{
"data": [
"Notice",
"Are you daydreaming or having trouble focusing? It is a sign that you need to take a break."
],
"enabled": true
},
{
"data": [
"Tech",
"How about taking a no-tech walk?"
],
"enabled": true
},
{
"data": [
"Metabolism",
"Emerging research shows that sitting for long periods of time contributes to risk of metabolic syndrome, heart attack and stroke risk and overall death risk, among others. Taking regular walking breaks can help your circulation, working to counteract some of those problems."
],
"enabled": true
},
{
"data": [
"Active Meetings",
"How about moving meetings from the conference room to the concourse? Walking not only burns calories but it may even foster a sense of collaboration."
],
"enabled": true
},
{
"data": [
"Fruit",
"Take your time and eat some fruit. Slowly. Notice the flavor, the texture, the freshness."
],
"enabled": true
},
{
"data": [
"Bathrooms",
"Walk to the farthest bathroom in the worksite facility when going to the restroom."
],
"enabled": true
},
{
"data": [
"Coffee break",
"Going on coffee break? Consider doing a 5-minute walk every time you go for one."
],
"enabled": true
},
{
"data": [
"Colleagues",
"Do not email or message office colleagues, walk to their desks to communicate with them."
],
"enabled": true
},
{
"data": [
"Learning",
"In a study of healthy volunteers, NIH researchers found that taking short breaks, early and often, may help our brains learn new skills."
],
"enabled": true
},
{
"data": [
"Exercise",
"Evidence suggests small amounts of regular exercise can bring dramatic health benefits, including measurably reducing stress."
],
"enabled": true
},
{
"data": [
"Repeat",
"Have you found your stretch-ly-routine? Do not forget to repeat it for more than once to better fight effects of prolonged sitting."
],
"enabled": true
},
{
"data": [
"Wrist and forearm",
"Extend your arms with the palms facing towards you, then slowly rotate the hands four times clockwise, then four times counter-clockwise."
],
"enabled": true
},
{
"data": [
"Back stretching",
"Join your hands behind your head, then lift them together up above your head ending with your palms facing upward."
],
"enabled": true
},
{
"data": [
"Mobilize",
"For every thirty minutes of stagnation, you should have at least one minute of stimulation."
],
"enabled": true
},
{
"data": [
"7 Minute Workout",
"This workout packs in a full-body exercise routine in a fraction of the time. But as with any exercise, be careful. There are numerous apps to get you started."
],
"enabled": true
},
{
"data": [
"Pulse",
" Raise your pulse rate to 120 beats per minute for 20 straight minutes four or five times a week doing anything you enjoy. Regularly raising your heart rate results in improved cardiovascular health."
],
"enabled": true
},
{
"data": [
"Take the stairs ",
"Studies have shown that stair climbing, which is considered vigorous-intensity physical activity, burns more calories per minute than jogging."
],
"enabled": true
},
{
"data": [
"Make art",
"Art therapy is known to have great mental health benefits, especially when it comes to stress management. How about writing a quick poem, taking a picture or painting something small?"
],
"enabled": true
},
{
"data": [
"Declutter",
"A clean space helps your focus at work and is often linked to positive emotions like happiness."
],
"enabled": true
},
{
"data": [
"Lunch outside",
"Nature is linked to positive emotions and decreased stress and anxiety. Whenever possible, try to take your daily lunch break outside, surrounded by some greenery."
],
"enabled": true
},
{
"data": [
"Public transport",
"If you use public transport regularly, you can stand instead of sitting. If it is possible, try to replace as many of your daily trips as possible with walking or cycling."
],
"enabled": true
},
{
"data": [
"Yawning",
"Yawning can be really helpful, as it produces tears to help moisten and lubricate the eyes."
],
"enabled": true
},
{
"data": [
"Focus change",
"Hold one finger close to the eye and focus on it. Slowly move the finger away, focus far into the distance and then back to the finger. Bring the finger back and focus on something far away."
],
"enabled": true
},
{
"data": [
"Palming",
"While seated, brace elbows on the desk and close to the desk edge. Let your weight fall forward and cup hands over eyes. Close your eyes and inhale slowly through nose and hold for few seconds. Continue deep breathing."
],
"enabled": true
},
{
"data": [
"Hand squeezes",
"Squeeze a pair of balled-up socks or a soft rubber ball, hold for 5 seconds. Repeat whole process few times."
],
"enabled": true
}
],
"microbreakIdeas": [
{
"data": "Go grab a glass of water.",
"enabled": true
},
{
"data": "Slowly look all the way left, then right.",
"enabled": true
},
{
"data": "Slowly look all the way up, then down.",
"enabled": true
},
{
"data": "Close your eyes and take few deep breaths.",
"enabled": true
},
{
"data": "Close your eyes and relax.",
"enabled": true
},
{
"data": "Stretch your legs.",
"enabled": true
},
{
"data": "Stretch your arms.",
"enabled": true
},
{
"data": "Is your sitting posture correct?",
"enabled": true
},
{
"data": "Slowly turn head to side and hold for 10 seconds.",
"enabled": true
},
{
"data": "Slowly tilt head to side and hold for 5-10 seconds.",
"enabled": true
},
{
"data": "Stand from your chair and stretch.",
"enabled": true
},
{
"data": "Refocus your eyes on an object at least 20 meters away.",
"enabled": true
},
{
"data": "Take a moment to think about something you appreciate.",
"enabled": true
},
{
"data": "Take a moment to smile at being alive.",
"enabled": true
},
{
"data": "A truly ergonomic workstation is one that you regularly push away from.",
"enabled": true
},
{
"data": "Close your eyes and count your breaths.",
"enabled": true
},
{
"data": "Close your eyes and name the things you hear.",
"enabled": true
},
{
"data": "Place your fingertips on your shoulders. Roll your shoulders forward for 10 seconds, then backward.",
"enabled": true
},
{
"data": "Raise your right arm, stretch it over your head to the left, and hold for 10 seconds. Repeat on the other side.",
"enabled": true
},
{
"data": "With your right hand, grab each finger of your left hand in turn and squeeze. Repeat on the other side.",
"enabled": true
},
{
"data": "Stand up and do a lunge. Hold for 10 seconds, then do the other leg.",
"enabled": true
},
{
"data": "Close your eyes and simply notice whatever arises in current moment, without judgement.",
"enabled": true
},
{
"data": "Focus every 20 minutes for 20 seconds on an object at 20 feet distance.",
"enabled": true
},
{
"data": "If you need help, ask for it.",
"enabled": true
},
{
"data": "Do one thing at a time.",
"enabled": true
},
{
"data": "Is your attention spent wisely?",
"enabled": true
},
{
"data": "Change your sitting posture.",
"enabled": true
},
{
"data": "Expose your eyes to natural light.",
"enabled": true
},
{
"data": "With your eyes closed, slowly and gently raise your eyes to the ceiling and back down to the floor.",
"enabled": true
},
{
"data": "With your eyes closed, slowly and gently move your eyes to the left, then slowly to the right.",
"enabled": true
},
{
"data": "Shake your hands out to get some relief.",
"enabled": true
},
{
"data": "One at a time, touch the tip of each finger to the tip of your thumb so they make an O-shape.",
"enabled": true
},
{
"data": "Make a fist and then slide your fingers up until they point toward the ceiling, like you're telling someone to stop.",
"enabled": true
},
{
"data": "Make a fist and then fan your fingers out and stretch them as far as you can.",
"enabled": true
}
],
"showBreaksAsRegularWindows": false,
"appExclusions": [],
"appExclusionsCheckInterval": 1000,
"pauseForSuspendOrLock": true,
"pauseBreaksShortcut": "",
"resumeBreaksShortcut": "",
"screen": "primary",
"timeToBreakInTray": false,
"currentTimeInBreaks": false
}
Additional information
Looks like postponing the long break too fast causes it to crash. Probably code an exception catch in there or have it abort when cancelled. Weirdly it doesn't crash when intentionally triggering long break using context menu
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
Thanks for the report! Will try to reproduce when I have 2 monitors nearby
I don't have physical Windows machine and on my Debian box all is fine. But looks like window is closed before all stuff for break is done.
Yes it takes a couple seconds to fully load on all monitors and if i need to skip it before it fully loads then it crashes it. It would be a good idea to code an exception catch in there or have it abort when skipped
Hey could you check new version, I've made some changes in how break windows are handled .
Thank you for looking into fixing this bug. Unfortunately it is still happening with version 1.11.0. Most recent crash log below:
[2022-08-18 17:01:21.187] [info] Stretchly: showing window 1 of 8
[2022-08-18 17:01:21.188] [info] Stretchly: starting Long Break
[2022-08-18 17:01:21.219] [info] Stretchly: showing window 2 of 8
[2022-08-18 17:01:21.475] [info] Stretchly: showing window 4 of 8
[2022-08-18 17:01:22.095] [info] Stretchly: showing window 3 of 8
[2022-08-18 17:01:22.146] [info] Stretchly: showing window 6 of 8
[2022-08-18 17:01:22.398] [info] Stretchly: showing window 5 of 8
[2022-08-18 17:01:22.854] [info] Stretchly: postponing Long Break
[2022-08-18 17:01:22.876] [info] Stretchly: showing window 7 of 8
[2022-08-18 17:01:22.884] [info] Stretchly: showing window 8 of 8
[2022-08-18 17:01:23.778] [error] TypeError: Cannot read properties of null (reading 'center')
at Timeout._onTimeout (C:\Users\user\AppData\Local\Programs\Stretchly\resources\app.asar\main.js:879:25)
at listOnTimeout (node:internal/timers:559:17)
at process.processTimers (node:internal/timers:502:7)
[2022-08-18 17:01:23.781] [error] TypeError: Cannot read properties of null (reading 'center')
at Timeout._onTimeout (C:\Users\user\AppData\Local\Programs\Stretchly\resources\app.asar\main.js:879:25)
at listOnTimeout (node:internal/timers:559:17)
at process.processTimers (node:internal/timers:502:7)
It gives 2 errors in this case. I'm guessing one error for each window.
It seems like one the lines in main.js like:
setTimeout(() => {
breakWinLocal.center()
}, 0)
is causing the crash. Maybe just change it to "if(breakWinLocal){breakWinLocal.center()}" for all occurrences? Though it might still crash later down the script if other breakWinLocal operations are done after without a null check
Looks like it stopped happening so far. I will report back if it still continues
This issue still happens unfortunately. But it looks like it has been reduced?