hound icon indicating copy to clipboard operation
hound copied to clipboard

Upgrade SwiftLint to 0.41.0 to Allow Inclusive Languages

Open shiki opened this issue 3 years ago • 2 comments

We're removing non-inclusive languages from our open source project. One of the remaining items is the whitelist_rules configuration we use for SwiftLint.

SwiftLint version 0.41.0 adds an inclusive version for this, only_rules (https://github.com/realm/SwiftLint/pull/3243). At the time of this writing, Hound only supports 0.27.0.

We tried setting the version directly in .hound.yml:

swiftlint:
    config_file: .swiftlint.yml	    config_file: .swiftlint.yml
    version: 0.41.0

But, as expected, Hound responded with:

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

It'd be great if 0.41.0 for SwiftLint is supported. 🙂

shiki avatar Nov 19 '20 00:11 shiki

According to the supported linters you only support version 0.27.0 of SwiftLint.
Why do you only support such an old version? This version is over two and half years old. Please keep the version up to date. Your service is nice, but such an old version is no-go.

mrgrauel avatar Feb 19 '21 09:02 mrgrauel

I can see that the Supported Linters page now lists 0.43.1 for SwiftLint... however, we're still getting the following error when we add PRs with that version of SwiftLint configured:

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

e.g. https://github.com/woocommerce/woocommerce-ios/pull/6956

It would be really helpful if these newer versions could be supported, or if there's any clues you can suggest about things I could check with our setup, I'd be grateful and happy to help with the investigation.

joshheald avatar May 26 '22 16:05 joshheald