hound icon indicating copy to clipboard operation
hound copied to clipboard

Notice changes to config.json or provide a way to trigger a re-read

Open emonty opened this issue 9 years ago • 16 comments

This falls into a bucket similar to #13 and #83 I think - which is "zomg I have lots of repos". In my case, I already have all of my repos referenced in a YAML file - so making a script to read that and write a config.json took about 5 minutes. However, we're always adding new ones - so I don't want to have to restart houndd to pick up new config.json changes if I don't have to.

I'd be happy to hack on this if it's something others think would be useful - or it might just be one of those things that comes out of the other work...

emonty avatar Apr 29 '15 02:04 emonty

:+1: Yes please.

chaseconey avatar Apr 30 '15 14:04 chaseconey

We've been trying to fit this into our schedule, but haven't made much progress. If you could implement it, that would be pretty awesome...

mmerrell avatar Apr 30 '15 19:04 mmerrell

:+1:

platan avatar May 05 '15 10:05 platan

(this is still on my TDL - haven't quite gotten to it yet ...)

emonty avatar Jun 04 '15 20:06 emonty

+1

sstarcher avatar Jun 05 '15 04:06 sstarcher

+1

gwindes avatar Jun 10 '15 17:06 gwindes

Because I'm being slow, we've found a human in the OpenStack community to work on this although it still may be a few weeks. @necrobuffalo wave to all the nice people

emonty avatar Jun 10 '15 18:06 emonty

+1, any update to this?

andydmei avatar Sep 01 '15 14:09 andydmei

I'm currently working on this patch :smile:

missaugustina avatar Sep 01 '15 20:09 missaugustina

:+1:

andydmei avatar Sep 02 '15 14:09 andydmei

I currently have something working, it still needs cleaning up, and I want to add test coverage and sanity check it. I'm using the fsnotify package to watch for changes to the configuration file. Right now I've also just got the configuration watcher and new searcher logic in the main houndd file, rather than having config publish some kind of event. I have a fork I'm working on if anyone wants to take a look and make suggestions. It's very WIP right now but I should have something ready to submit for review this week or next. https://github.com/etsy/hound/compare/master...missaugustina:bug_119_recheck_for_new_repos

missaugustina avatar Sep 27 '15 19:09 missaugustina

@missaugustina just looking at this right now, but having difficulty in getting it to work locally. Any updates or a PR in the works?

diemonster avatar Nov 09 '15 19:11 diemonster

+1

nus avatar Feb 15 '16 14:02 nus

Anymore updates? Right now it takes me 10 minutes to restart hound and have it serving requests again.

cheethoe avatar Feb 24 '16 18:02 cheethoe

ohai! Now I know why puppet is disabled on codesearch.o.o :)

pabelanger avatar Mar 02 '17 17:03 pabelanger

Do we have some news here? Would love to see this happening :(

dbarranco avatar Jun 07 '18 18:06 dbarranco