acf-icon-picker icon indicating copy to clipboard operation
acf-icon-picker copied to clipboard

Incompatible with Internet Explorer 11

Open ajreading opened this issue 4 years ago • 2 comments

The plugin uses template literals, or backtick strings (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals) within assets/js/input.js which means that it causes JavaScript errors when accessing the site from IE11. This unfortunately breaks many of WordPress' admin screens which depend upon JavaScript functionality.

I appreciate that WordPress are currently considering dropping IE11 support, but that may still be up to a year away.

It would be a relatively simple fix to support IE11 by replacing the backticks with some quotes and concatenation instead.

ajreading avatar Mar 31 '21 14:03 ajreading

Yes, this plugin was not designed with old browsers in mind as I've dropped IE11 support for a while now. I might add this when I release a new update, but I've not planned one for the foreseeable future.

Feel free to submit a PR though :)

houke avatar Mar 31 '21 14:03 houke

Thanks. I've submitted a PR #25

ajreading avatar Apr 12 '21 11:04 ajreading

Closing due to not needed support for IE11

klaudiomilankovic avatar Feb 16 '23 13:02 klaudiomilankovic