inventory-count icon indicating copy to clipboard operation
inventory-count copied to clipboard

Scrollbar margin issue in cycle count review

Open AjinkyaM1 opened this issue 9 months ago • 7 comments

Description: The scroll bar on the Cycle Count Review screen has a narrow margin between the checkboxes, making it difficult for users to interact with one without accidentally triggering the other.

Steps to Reproduce:

  1. Navigate to the Cycle Count Review screen.
  2. Attempt to check/uncheck a checkbox near the scroll bar.
  3. Notice that interacting with one element often catches the other.

Expected Behavior: There should be a wider margin between the checkboxes and the scroll bar to ensure smooth user interaction.

Proposed Solution: Increase the spacing between the checkboxes and the scroll bar to prevent accidental interactions.

AjinkyaM1 avatar Mar 13 '25 05:03 AjinkyaM1

I believe there is a way to detect if the users browser has scrollbar always visible or if it is visible on scroll. The styling we add should only apply to users when their browser has scroll bar visible on scroll.

The implementation should be to add padding to the item overall instead of just the checkbox.

Image

dt2patel avatar Mar 22 '25 01:03 dt2patel

@dt2patel Sir,

Explored around the possible ways to detect scroll visibility in case of overlay scrollbars, but didn't found anything promising. https://issues.chromium.org/issues/41089158 https://css-tricks.com/designing-show-scroll-bars/

One solution is to use capacitor plugin for getting device preference and then add the specific styling(need to check the specific plugin to be used for getting scrollbar preference).

ymaheshwari1 avatar Mar 26 '25 11:03 ymaheshwari1

@dt2patel Sir, need to discuss on this as well. As per Ajinkya this is on priority.

ymaheshwari1 avatar Apr 03 '25 04:04 ymaheshwari1

This is not priority issue. They can live with this

dt2patel avatar Apr 03 '25 04:04 dt2patel

@ymaheshwari1 agreed that there is no way simple way that I was thinking of to detect scrollbar presence. Instead lets just add a static padding to the end to the list item css class for desktop view.

dt2patel avatar May 08 '25 22:05 dt2patel

@dt2patel sir,

Are we adding this padding in the global apps theme repo or just in our app locally.

amansinghbais avatar May 09 '25 08:05 amansinghbais

If it looks good here I think we can add it to global package

dt2patel avatar May 09 '25 09:05 dt2patel

Working fine in v2.9.0, hence closing this issue.

shubham-namdeo avatar Jun 03 '25 05:06 shubham-namdeo