tasking-manager icon indicating copy to clipboard operation
tasking-manager copied to clipboard

Update Rapid to v2.3.1 from v2.1.x

Open tsmock opened this issue 1 year ago • 8 comments

There are fairly minimal changes required for this to work.

About the only thing of note is Rapid requires node 18 or later. Setting the NODE_OPTIONS=--openssl-legacy-provider environment variable will work around the following issue (see #6053):

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:69:19)
    at Object.createHash (node:crypto:133:10)
    at module.exports (frontend/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (frontend/node_modules/webpack/lib/NormalModule.js:417:16)
    at frontend/node_modules/webpack/lib/NormalModule.js:452:10
    at frontend/node_modules/webpack/lib/NormalModule.js:323:13
    at frontend/node_modules/loader-runner/lib/LoaderRunner.js:367:11
    at frontend/node_modules/loader-runner/lib/LoaderRunner.js:233:18
    at context.callback (frontend/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at frontend/node_modules/react-scripts/node_modules/babel-loader/lib/index.js:59:103 {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'

This depends upon moving to node 18 (see #5908).

EDIT: We are now on node 18.

tsmock avatar Jan 16 '24 20:01 tsmock

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jan 16 '24 20:01 sonarqubecloud[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 20 '24 13:02 sonarqubecloud[bot]

@tsmock how can we go ahead on this PR ?

varun2948 avatar May 02 '24 08:05 varun2948

~~@varun2948 : If you don't mind the failing frontend-code-test job, yes.~~

~~I think it should have been fixed by #6397. I did just rebase, and it is still failing.~~

EDIT: It looks like I didn't wait long enough for the job to get picked up and looked at the older run.

tsmock avatar May 02 '24 12:05 tsmock

Next steps here is testing on dev server. Prioritising this for next release @royallsilwallz @manjitapandey @varun2948

ramyaragupathy avatar May 08 '24 05:05 ramyaragupathy

Found few errors on testing: Uploading of edits failed: An unknown crash occurs when trying to upload the edits on rapid editor. Steps to reproduce

  • Draw few features using rapid editor.
  • Click on save to upload the features on osm.
  • See error. image

Refresh the page to get upload page on left panel. 404 error pop-up is seen. image

manjitapandey avatar May 13 '24 11:05 manjitapandey

@manjitapandey : That should be fixed now.

tsmock avatar May 13 '24 14:05 tsmock

hey @tsmock, can you rebase to the latest develop branch and push?

royallsilwallz avatar May 22 '24 07:05 royallsilwallz

The version upgrade will be from v2.2.5 to v2.3.1 since rapid got accidently upgraded to v2.2.5 in this PR during yarn lock generation.

royallsilwallz avatar May 23 '24 03:05 royallsilwallz

From @manjitapandey on slack:

I was testing the Rapid version upgrade PR on Naxa server. Everything works fine except I can't see microsoft buildings and facebook roads which are available on same area in rapid website. The next step we are thinking is to merge the PR on HOT dev server and test it again before the release.

ramyaragupathy avatar May 30 '24 05:05 ramyaragupathy