tasking-manager icon indicating copy to clipboard operation
tasking-manager copied to clipboard

Add a temporary workaround to get building on Node 18 since Node 16 EOL is 2023-09-11

Open tsmock opened this issue 1 year ago • 2 comments

This does the following:

  • Add NODE_OPTIONS=--openssl-legacy-provider (not needed once we upgrade to react-scripts v5 or remove/replace react-scripts)
  • Only adds NODE_OPTIONS when run on node 18 or later
  • Performs frontend-code-test on node 18
  • Does not run backend_deploy/frontend_deploy with node 18. This can be changed via using cimg/python:3.10-node (versions after 3.10.8-node use node 18 instead of node 16)

Node 16 EOL Notice: https://nodejs.org/en/blog/announcements/nodejs16-eol create-react-app --openssl-legacy-provider: https://github.com/facebook/create-react-app/issues/11562

This is intended to be a temporary fix for #5767.

tsmock avatar Sep 08 '23 13:09 tsmock

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

sonarqubecloud[bot] avatar Sep 08 '23 13:09 sonarqubecloud[bot]

We built some node images for this issue while we work to get TM running on a newer version: https://quay.io/repository/hotosm/node?tab=tags

dakotabenjamin avatar Oct 12 '23 15:10 dakotabenjamin

@varun2948 @tsmock - with the node upgrade coming from #5721 merge is this relevant?

cc @royallsilwallz @manjitapandey

ramyaragupathy avatar May 01 '24 11:05 ramyaragupathy

Nope. We can close this.

tsmock avatar May 01 '24 13:05 tsmock