tasking-manager
tasking-manager copied to clipboard
hotosm
Improve UI for validation of self-mapped tasks
From https://github.com/hotosm/tasking-manager/issues/5086#issuecomment-1094172653
Is your feature request related to a problem? Please describe.
When a task has been mapped by myself, I cannot validate it. When I select the task and click the Validate task button, an error message pops up correctly, preventing me from validating the task I mapped myself. This is good.
Describe the solution you'd like
It would be better if the UI showed me that I mapped the task myself, before showing the Validate task button, and doesn't let me click the button.
It might show a short explanation below the button why I cannot validate the task.
Possibly related to https://github.com/hotosm/tasking-manager/issues/3746
Will changing this also then impact on tasks that a validator has opened for validation and corrected some of the mapping before marking it valid,
Some discussion on this issue took place during the Tasking Manager meet up. A few options were suggested: Option 1: Make the tasks not clickable Option 2: Allow users to click on the task but notify users with a pop up Option 3: Add a new label to the legend section that would have a separate colour for the tasks you mapped (adds a bit of complexity)
The group agreed that we need to consult with more users on the best option, considering the pros and cons, before implementing the change.
My personal opinions on this:
Option 1: looks good to me if there is a message on hover like "Mapped by you" as shown below:
Option 2: I feel there is no point giving user to click on the task when the action after click is just showing pop up, also it might confuse if there is multiple tasks selection
Option 3: There are already 6 colors used in this view, adding new as said can be complex.
tl;dr: I agree with @Ichchhie's opinions 😃. I think we're already pushing the limits of the color coding system which is why we added the lock icon when we built TM4. I think a tooltip on hover would be the best option of the 3.
One other thought I had was to take the popup one step further and make a general hover popup for any task to show a "condensed" history of the task. I've thought of this in two different ways:
- same thing as Ichchha's image but we just show whoever did the last action on the task (maybe it was "invalidated by"
- Show an actual small list of the history. For instance "Mapped by Ichchha", "Invalidated by Petya", "Mapped by Ichchha", "Validated by Aadesh". I would imagine these 3 items would be the longest form we'd need to show. This option is definitely the more utilitarian but could be a bit clunky and goes a bit beyond the original request 😃.
It works good for tasks that I mapped before BUT it behaves the same also if I lock a task for validation and then unlock, I can't click on it anymore. I can still select it from the task list and validate it again but I can't click on the task on the task map.
It works good for tasks that I mapped before BUT it behaves the same also if I lock a task for validation and then unlock, I can't click on it anymore. I can still select it from the task list and validate it again but I can't click on the task on the task map.
Thank you @Patrik-Br for testing so well. We replicated the issue you mentioned. Will need to work on it and let you know once the issue is fixed.