tasking-manager icon indicating copy to clipboard operation
tasking-manager copied to clipboard

Documentation link for postgres docker image is broken

Open Abhirup-99 opened this issue 4 years ago • 5 comments

I was setting up backend but found the documentation link for postgres docker image is broken. What would be the way forward?

Abhirup-99 avatar Feb 10 '21 21:02 Abhirup-99

@willemarcel can you help with this one.

Abhirup-99 avatar Feb 13 '21 12:02 Abhirup-99

@Abhirup-99 can you elaborate ? Where did you see the link to the documentation?

eternaltyro avatar Apr 14 '23 21:04 eternaltyro

I have also seen this link. After a bit of investigation, the Dockerfile was essentially

# This was `FROM mdillon/postgis` -- see removal commit for original
FROM postgis/postgis:latest

ENV POSTGRES_USER hottm
ENV POSTGRES_PASSWORD hottm
ENV POSTGRES_DB tasking-manager

It was removed in 91ba9d405e3443199343a147e227cafea33d256e.

As for where references to the missing Dockerfile are located, see https://github.com/hotosm/tasking-manager/blob/develop/docs-old/setup-development.md#build--run-the-postgis-dockerfile and https://github.com/hotosm/tasking-manager/blob/develop/docs/developers/development-setup.md#build--run-the-postgis-dockerfile .

We could probably replace it with docker run --env POSTGRES_USER=hottm --env POSTGRES_PASSWORD=hottm --env POSTGRES_DB=tasking-manager --publish 5432:5432 postgis/postgis:latest. Someone should double check that -- I tested with podman, but it should work with docker.

tsmock avatar Apr 27 '23 12:04 tsmock

@spwoodcock - does your PR on separating swagger in docker fixes this? Can you please verify?

ramyaragupathy avatar Apr 11 '24 14:04 ramyaragupathy

No it's unrelated, but this issue can be solved with a small docs update.

I personally don't think we need such comprehensive documentation for how to set up a standalone postgres container. That's outside the scope of TM.

We do this by default in the development docker compose config. If the user wants to change the default config to their spec with TM inside containers, but also linking to a separate database in containers too, I think they will know how to do this anyway.

spwoodcock avatar Apr 11 '24 14:04 spwoodcock