Android-Rate icon indicating copy to clipboard operation
Android-Rate copied to clipboard

Published 20 hours ago • verified publisher icon hotchemi

setRemindInterval takes only time

Open phajduk opened this issue 9 years ago • 3 comments

Hi. I would like to implement method similar to setRemindInterval but it would take number of launches of the app instead of days. Name proposition is setRemindLaunchTimes. It would allow us to show the dialog again after for example next 5 launches. @hotchemi what do you think?

phajduk avatar Apr 14 '16 11:04 phajduk

I checked the code and it looks like if we go for it then this will be complicated much more. I'm also wondering what will happen when we setup for example:

.setInstallDays(10)
.setLaunchTimes(3)

Will it be shown after 3rd launch which has been made before 10th day? I think it's not. Is it intended?

phajduk avatar Apr 14 '16 13:04 phajduk

Exact same questions here. Thanks!

Foivos-Stamopoulos avatar Apr 26 '16 11:04 Foivos-Stamopoulos

I've created a pull request for this feature as I am also looking for this. I'm not 100% certain I updated everything I needed and didn't see any tests but hoping this does the trick...

https://github.com/hotchemi/Android-Rate/pull/134

adamfisher avatar Oct 17 '17 20:10 adamfisher