Pieter Hoste

Results 45 issues of Pieter Hoste

The upcoming PHP 8.4 release will contain a new deprecation: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types However, this conflicts with the minimum PHP version this module requires, which is currently at PHP 7.0, which didn't...

We should add some checks to see if url_key's in the database are normalized or not (contain unexpected characters). If they aren't normalized these can cause bad things. Apparently there...

Just ran into an issue on a shop where the url_key for the category exists on a certain storeview, but the url_path is missing: ``` mysql> SELECT * FROM catalog_category_entity_varchar...

It looks like we missed this change: https://github.com/magento/magento2/pull/22182/files#diff-13ecb83df145aeed92db4448b724e4b2f3ea323877a09deb46c6ba8d393f9ff2 which got included in Magento 2.3.4 and higher. We should take a look to see if it's worth implementing this on our...

Hi guys I'm trying to upgrade this module from version 1.3.8 to 1.4.2 (see [changes](https://github.com/Smile-SA/magento2-module-custom-entity-product-link/compare/1.3.8...1.4.2)) But we are noticing an extremely slower reindex of the `catalogsearch_fulltext` indexer. With version 1.3.8,...

### Preconditions and environment - Magento version 2.4.6-p3 (but most likely all versions will be affected) ### Steps to reproduce Explanation below how to trigger this with a cronjob from...

Component: Cron
Issue: Confirmed
Reproduced on 2.4.x
Progress: PR in progress
Priority: P2
Area: Catalog
Reported on 2.4.6-p3

Hi guys I think in https://github.com/algolia/algoliasearch-magento-2/pull/1474, it was forgotten to also remove the polyfill.io domain name from the `csp_whitelist.xml` file. This is only a minor cleanup. This was brought to...

Ported to Jira

While trying to figure out after a big update of dependencies why quality setting of yireo's webp2 module no longer seems to work, I discovered some things. Some links: -...

### Description (*) These were found by running phpstan with level 0 on all code in `app/code/Magento` The first commit deals with the description here, further commits are to fix...

Progress: accept
Triage: Dev.Experience
Priority: P2
Project: Community Picked

### Description (*) This is just some minor cleanup. We called a method that didn't return anything (void) and then used that result value. Which is really not needed. Found...

Progress: approved
Project: Community Picked