react-native-dropdown-picker icon indicating copy to clipboard operation
react-native-dropdown-picker copied to clipboard

Theme Style Object keys are different to Prop style names

Open JDMathew opened this issue 2 years ago • 1 comments

On more than one occasion I have struggled to switch from adding styles via the Theme vs via DropDown Props. This is because the names are different the prop may be called labelContainerStyle but then the Theme object key is labelContainer It would be good if these were the same as it would make applying props through spread syntax easier. I know this would require complexity on the library side to manage names but it would make using the component more fluid.

JDMathew avatar Apr 13 '22 11:04 JDMathew

Maybe propose a specific mapping as a plan for a PR, then if it's good a PR would be possible + have consensus before any possible wasted effort? There are a lot of issues in the library that reduce to "feature discoverability" with regards to styling, so the effort might pay off even via a strict "is it a useful spend of maintainer time" criteria, over time in reduced issue/support traffic

mikehardy avatar Apr 13 '22 17:04 mikehardy