streamline icon indicating copy to clipboard operation
streamline copied to clipboard

Rename StreamlineEventImpl to DefaultStreamlineEvent and move it to streamline-sdk

Open priyank5485 opened this issue 7 years ago • 3 comments

As per the discussion here https://github.com/hortonworks/streamline/pull/963#discussion_r144694050

priyank5485 avatar Oct 17 '17 03:10 priyank5485

I suggest that the interface is called Event or InternalEvent (if you want to avoid possible name collision with some libraries) and the default (for streamline) implementation is called StreamlineEvent. DefaultStreamlineEvent is too long of a name and I don't think the naming prefix default is appropriate here.

hmcl avatar Oct 17 '17 04:10 hmcl

The interface is already called StreamlineEvent. Lets retain that else will lead to huge refactoring and maybe backward incompatible. For our internal implementation DefaultStreamlineEvent or StreamlineEventInternal sounds good.

We also need to re-visit if the interface should extend the map interface. It better to get this done in the next release before its too late.

arunmahadevan avatar Oct 17 '17 05:10 arunmahadevan

@arunmahadevan if possible I would like to avoid such long names. I understand the concern on changing the name of the interface. Perhaps we can call the default implementation simply InternalEvent or DefaultEvent as the substring Streamline can become quite verbose imho.

hmcl avatar Oct 17 '17 15:10 hmcl