streamline
streamline copied to clipboard
hortonworks
Adding reviewers ids in generated commit messages through merge script.
Merge script does not have reviewers ids in generated commit messages. It is good to have that information in commit messages like Apache Kafka/Spark. @HeartSaVioR added that as part of registry merge script, can streamline's merge script is updated with that?
Would be better to link some commits in registry which has the reviewer informations. Unlike Apache Kafka/Spark, we automated adding reviewers based on Github review feature.
Would be better to link some commits in registry which has the reviewer informations.
registry related script is located here.
Unlike Apache Kafka/Spark, we automated adding reviewers based on Github review feature.
I guess that was done as those APIs have some rate limits. Having reviewers ids should be fine by using Github review feature.
https://github.com/hortonworks/registry/commit/48726b8cd36188f36c9599b5717d6f96255bd782
ISSUE-273: Transaction support in storage layer.
- Transaction support in storage layer
- Made registry storage transactional using these new APIs.
Author: Sarvanan Raju <[email protected]>
Reviewers: @satishd,@raju-saravanan
Closes #286 from raju-saravanan/txn
Please refer the line starting with Reviewers: . We just use github ID since we need to query each reviewer for retrieving name and email as well. There's rate limit in query as @satishd pointed out.
ps. Showing is believing. :)