registry icon indicating copy to clipboard operation
registry copied to clipboard

SchemaRegistry client and serdes modules un-needed dependencies.

Open michaelandrepearce opened this issue 7 years ago • 3 comments

Currently when bringing into projects Schema Client and the Schema Serdes the transitive dependencies is very large, increasing risk of dependency conflict.

Such dependencies such as org.apache.hadoop:hadoop-client:jar, and hibernate which should simply not be needed by a pure kafka or another other client not on hadoop, should not need, but makes a very large transitive deps.

This seems to be due to a common dependency on registry-common which brings these in, and probably should therefor be split out, or excluded.

This should be reduced to just the core dependencies needed to function, for each component.

michaelandrepearce avatar Aug 08 '17 16:08 michaelandrepearce

@satishd @harshach to do this rather than having to a bunch of dirty dependency excludes, i am thinking of splitting the common module into:

  • common-client
  • common-server

where common-server depends on common-client and common-client is as lightweight as possible. wdyt?

michaelandrepearce avatar Aug 09 '17 22:08 michaelandrepearce

@michaelandrepearce +1 to make client module having minimal dependencies. Ideally, common-server should not depend upon common-client but both can have dependencies on a single common module. It should also be taken into account that registry-common module is used by http://github.com/hortonworks/streamline project and respective changes to be done there once the changes are done here.

satishd avatar Aug 10 '17 05:08 satishd

+1

HdfsFileStorage is clearly server side class so shouldn't be included to common, and it's only usage of hadoop-common.

HeartSaVioR avatar Aug 10 '17 05:08 HeartSaVioR