cloudbreak-deployer icon indicating copy to clipboard operation
cloudbreak-deployer copied to clipboard

CB-13978: Show a warning when cbd looks up Profiles from the PATH.

Open brycederriso opened this issue 4 years ago • 3 comments

Closes CB-13978.

brycederriso avatar Aug 31 '21 14:08 brycederriso

Made a mistake, still testing this.

brycederriso avatar Aug 31 '21 14:08 brycederriso

Ganesh pointed out that this doesn't gracefully deal with . in the $PATH.

Further, I'm getting errors when running this locally:

 cbd start
[DEBUG][init-profile             ] Use existing profile: Profile
++ sort -u
+++ echo /Users/brycederriso/bin:/Users/brycederriso/Library/Python/3.7/bin:/Users/brycederriso/go//bin:/Users/brycederriso/bin:/Users/brycederriso/Library/Python/3.7/bin:/Users/brycederriso/go/bin:/usr/local/opt/[email protected]/bin:/usr/local/opt/findutils/libexec/gnubin:/usr/local/opt/grep/libexec/gnubin:/usr/local/opt/gnu-sed/libexec/gnubin:/Users/brycederriso/Library/Python/3.7/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/brycederriso/bin:/Users/brycederriso/Library/Python/3.7/bin:/Users/brycederriso/go//bin:/Users/brycederriso/go/bin:/usr/local/opt/[email protected]/bin:/usr/local/opt/findutils/libexec/gnubin:/usr/local/opt/grep/libexec/gnubin:/usr/local/opt/gnu-sed/libexec/gnubin:/usr/local/sbin:/usr/local/go/bin:/Users/brycederriso/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/local/go/bin:/Users/brycederriso/.local/bin
+++ sed 's/:/ /g'
++ find /Users/brycederriso/bin /Users/brycederriso/Library/Python/3.7/bin /Users/brycederriso/go//bin /Users/brycederriso/bin /Users/brycederriso/Library/Python/3.7/bin /Users/brycederriso/go/bin /usr/local/opt/[email protected]/bin /usr/local/opt/findutils/libexec/gnubin /usr/local/opt/grep/libexec/gnubin /usr/local/opt/gnu-sed/libexec/gnubin /Users/brycederriso/Library/Python/3.7/bin /usr/local/bin /usr/bin /bin /usr/sbin /sbin /Users/brycederriso/bin /Users/brycederriso/Library/Python/3.7/bin /Users/brycederriso/go//bin /Users/brycederriso/go/bin /usr/local/opt/[email protected]/bin /usr/local/opt/findutils/libexec/gnubin /usr/local/opt/grep/libexec/gnubin /usr/local/opt/gnu-sed/libexec/gnubin /usr/local/sbin /usr/local/go/bin /Users/brycederriso/.local/bin /usr/local/sbin /usr/local/bin /usr/local/go/bin /Users/brycederriso/.local/bin -name Profile
+ PROFILES_ON_PATH='/Users/brycederriso/bin/Profile
/Users/brycederriso/bin/test/Profile
/usr/local/bin/Profile'
2021/08/31 13:07:07 exit status 1

brycederriso avatar Aug 31 '21 18:08 brycederriso

An example of the output:

$ cbd ps
[WARN] Multiple Profiles found on your path will be used, this might not be desirable: /Users/brycederriso/bin/Profile
      Name                     Command               State                    Ports
-----------------------------------------------------------------------------------------------------
cbreak_commondb_1   /bin/bash -c cd /var/lib/p ...   Up      0.0.0.0:5432->5432/tcp,:::5432->5432/tcp
cbreak_vault_1      docker-entrypoint.sh server      Up      0.0.0.0:8200->8200/tcp,:::8200->8200/tcp

It's not perfect, but at least gives a warning.

brycederriso avatar Sep 09 '21 19:09 brycederriso