DIE-engine Update weblinks

making the weblinks more readable when in light or dark mode

Mar 04 '25 06:03 DevX-Cipher

Thanks! But where is "updateLinkColors" function?

Mar 04 '25 08:03 horsicq

fixed the mistake sorry

Mar 04 '25 08:03 DevX-Cipher

@CR-GalShav-Artza i updated the code i missed ages ago hors hasn't accepted they re busy

Apr 14 '25 12:04 DevX-Cipher

just a friendly ping here... @horsicq ! :)

May 13 '25 06:05 greenozon

@greenozon they're busy

May 13 '25 06:05 DevX-Cipher

every question has an answer.. so lets figure out!

May 13 '25 07:05 greenozon

great progress! :+1:

Jun 23 '25 09:06 greenozon

@DevX-Cipher what is the status of this PR?

Jun 29 '25 09:06 BJNFNE

Just waiting on @horsicq

Jun 29 '25 10:06 DevX-Cipher

Thank you @DevX-Cipher i disscued with hors about the Merge

Jun 29 '25 12:06 BJNFNE

@BJNFNE no worries sorry I have been busy

Jun 29 '25 12:06 DevX-Cipher

@DevX-Cipher It looks like your code is incorrect, I compiled it yesterday on my machine locally as an new instance and there it works, but in DiE itself it has alot of compiling errors. so we have to revert it :(

Jun 30 '25 16:06 BJNFNE

the changes in the code looks minimalist... what kind of errors do you hit?

Jun 30 '25 16:06 greenozon

@greenozon https://github.com/horsicq/Detect-It-Easy/issues/243#issuecomment-3017993781

Jun 30 '25 16:06 BJNFNE

https://github.com/horsicq/DIE-engine/commit/b4ef0f6a47228cd8b6a84a80d069e7b4eab007ed

Jun 30 '25 16:06 BJNFNE

@BJNFNE it works for me i will double check it again today

Jun 30 '25 23:06 DevX-Cipher

@BJNFNE there is no error building for macOS or linux with the weblinks i created

Jul 01 '25 04:07 DevX-Cipher

Yes i know, but does not happens locally it only happens after the merge

Jul 01 '25 05:07 BJNFNE

Was there something wrong with my merge?

Jul 01 '25 06:07 DevX-Cipher

It had alot of compiler errors

Jul 01 '25 06:07 BJNFNE

@greenozon https://github.com/horsicq/Detect-It-Easy/issues/243#issuecomment-3017993781

See here last Code where webLinks() is referenced in the errorlog

Jul 01 '25 06:07 BJNFNE

@BJNFNE I’ve successfully compiled the project without any errors across Linux, macOS, and Windows. I'm currently trying to reproduce the issue, but so far I haven’t encountered any of the compile errors being reported. It’s unclear to me how these errors are occurring based on my current tests.

Jul 01 '25 06:07 DevX-Cipher

@BJNFNE I’ve successfully compiled the project without any errors across Linux, macOS, and Windows. I'm currently trying to reproduce the issue, but so far I haven’t encountered any of the compile errors being reported. It’s unclear to me how these errors are occurring based on my current tests.

You used Clang right?

We used gcc/g++ for that, i also think i dif not added it to Build.md i may should add proper clang compile instructions there.

Jul 01 '25 06:07 BJNFNE

i tried both clang and gcc and it still compiled fine

Jul 01 '25 06:07 DevX-Cipher

i tried both clang and gcc and it still compiled fine

Weird... I tried it aswell locally on my PC as mentioned there worked it fine too, but not in the Master,

Maybe we should build an PR CI so when an new PR is made they precompile it to see if any conflicts can happen with the current Master Branch? Whats your opinion about it?

Jul 01 '25 06:07 BJNFNE

i think maybe because my branch was outdated and didn't have the new changes might have been causing a conflict

Jul 01 '25 06:07 DevX-Cipher

@BJNFNE do you want it a separate one or in the builder.yml

Jul 01 '25 06:07 DevX-Cipher

i think maybe because my branch was outdated and didn't have the new changes might have been causing a conflict

Can you may rebase it and check if you get then the errors? And fix them then?

Your Changes looks good from the code also in the GUI :)

Jul 01 '25 07:07 BJNFNE