Maxim Vladimirskiy

It seems to be too use case specific to be included as a parser option. I can think of many similar specific use cases e.g.: do not allow domains of...

I do not think it makes sense to pin `tld` in the library, for python3 users may not be happy about it. If the library is used by a Python2...

I am not saying that we do not support python 2. I am saying it is your application responsibility to pin versions. Each our python application has `requirements.txt` file where...

I was not the one who originally wrote this, but the docstring states that the method takes `addr_spec` which i suppose means just email address, no display name. I personally...

What version are you using?

Have you acknowledged all consumed messages before stopping? Alternatively you could have used [auto_ack=true](https://github.com/mailgun/kafka-pixy/blob/master/kafkapixy.proto#L190-L192) when consuming. Before stopping `kafka-pixy` waits for acknowledgments of consumed messages for [proxies.\.consumer.ack_timeout](https://github.com/mailgun/kafka-pixy/blob/master/default.yaml#L146-L148) which is 5...

> That seems like a long time for a process to wait after a SIGTERM (especially without logging an explanatory message). If `kafka-pixy` stops immediately that would result in unacknowledged...

I agree with the first two suggestions, however we will not implement the third, because a user have an option to auto ack consumed messages.

@eajazali87 in the release package you can find `testconsumer` and `testproducer` binaries provided precisely for load testing. E.g.: ``` ./testconsumer --addr localhost:19091 --topic demo --count 1 --group foo ./testproducer --addr...

I am glad that you figured it out. It would be great if in the end you could share the results of your load testing. Maybe post them in this...