Maxim Vladimirskiy comments

Results 42 comments of


                                            Maxim Vladimirskiy

POST with TLS causes double-close on body producer

Still happening in Twisted v17.9.0 and treq v17.8.0

POST with TLS causes double-close on body producer

It has been awhile since the last update. Is it on the roadmap?

Restore compatibility with older versions of regex

@b0d0nne11 tests seems to be passing. I have no objections.

parsing a list of addresses returns empty set if there is an invalid email

Passing comma separated string to `parse_list` is an anti-pattern, because the ambiguity of grama does not allow reliably parse lists that contain garbage like this one. It is better pass...

parsing a list of addresses returns empty set if there is an invalid email

You are right, the documentation needs to be updated. The comma separated string parser used to work kind of ok, before support for UTF-8 addresses was added. At that point...

Any one email contains non-ASCII characters return all emails are invalid even valid email present

Passing a comma separated string to `validate_list` is suboptimal. Due to grama ambiguity the result may not be what you want it to be. When possible it is always better...

Any one email contains non-ASCII characters return all emails are invalid even valid email present

You are using a non-ASCII literal in a file that does not have encoding declared. Add `# coding:utf-8` as the first line of your file.

is_valid_email returns different values for same input

This behavior is probably a result of DNS queries for the domain MX records returning inconsistent results. You can confirm that by running command `dig MX ` a few times...

MimePart.to_string() can produce different output depending on MimePart.was_changed()

All is reasonable. I would prefer the soft line breaks option. @b0d0nne11 what do you think?

MimePart.to_string() can produce different output depending on MimePart.was_changed()

@mhahnenberg the idea is that if we do not need to make changes to the mime the we return it as is. This is intentional. Originally we did encode message...