horilla icon indicating copy to clipboard operation
horilla copied to clipboard

updated horilla app

Open Sambhav-rapidinnovation opened this issue 8 months ago • 3 comments

please check this

Sambhav-rapidinnovation avatar Apr 03 '25 04:04 Sambhav-rapidinnovation

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - SMTP credentials 0c877b23165de8ee89a6612973ef5c06413835ff horilla/settings.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Apr 03 '25 04:04 gitguardian[bot]

Hi @Sambhav-rapidinnovation ,

Thank you for your contribution!

We appreciate the effort put into this update.

Since this is a large PR with significant changes, we will need some time to review it thoroughly.

Our team will go through the updates and get back to you soon with feedback. Stay tuned!

Happy to have you as part of Horilla Community

Best Regards, Team Horilla

horilla-opensource avatar Apr 03 '25 04:04 horilla-opensource

Hi @Sambhav-rapidinnovation,

We've noticed some updates in the project, including renaming project to project_horilla and modifying horilla/urls.py.

Could you please revert the name back to project? Also, instead of directly adding the app's urls.py to urlpatterns in horilla/urls.py, it's better to include it from the ready function in apps.py. This way, users can simply comment out the app in settings.py if they want to disable it, without needing to modify multiple files.

Additionally, Could you please rename your app name project to finance_project.

We suggest adding customizations in a new app instead of modifying the existing one to ensure better maintainability and easier integration.

Let us know if you have any questions. Thanks for your contributions!.

Looking forward for your updates on the PR

Best regards,
Team Horilla

horilla-opensource avatar Apr 03 '25 14:04 horilla-opensource