right-click "add suggestion as branch" when at the end of an existing branch

[Trevoke]

When at the end of an existing non-main branch and using the "add suggestion as branch" tool, it adds the suggestion as a new branch instead of as a continuation of the current branch, which doesn't make a lot of sense to me, and which means we can't easily scroll up or down to go through the moves: the "variation" point requires a different interaction.

[hope366]

In other words, do you want to add it as an extension of the main orbit instead of "adding as a branch"? What is the preferred specification for interaction with up / down scrolling when there are multiple branches?

[Trevoke]

For the addition of the variation

If I am in the middle of a variation branch

The AI suggested variation should be added as a new branch

If I am at the end of a variation branch

The AI suggested variation should be added as an extension of the current branch

If I am in the middle of the main branch

The AI-suggested variation should be added as a new branch

If I am at the end of the main branch

The AI-suggested variation should be added as a branch (and if the user wants this to be part of the main branch, they can click the "Set as main" button)

For the scroll-up-down behavior

Lizzie's default behavior, which is the same behavior as many of the SGF editors out there, is to assume the user wants to continue down the "current" branch, which is really "the first branch created", so:

If I have one branch

using the mouse wheel in lizzie should just go up and down the main branch

If I have one main branch and one variation branch

using the mouse wheel in lizzie should just go up and down the current branch. if I am on the variation branch and I scroll up enough to be back on the main branch, then it is fine if we revert back to moving up and down the main branch. Nice to have: remember what branch we're on.

If I have one main branch and two variation branches off of the main branch

Same behavior as above

If I have one main branch, one variation branch, and a variation off of the variation branch

We'll call the main branch M, the first variation A, and the second variation B. Scrolling on A should behave as above. Scrolling on B should behave normally. If we scroll up enough that we get to A, we should revert to the above behavior.

In other words, always default to the branch closest to the main branch.

[hope366]

Thank you for your interesting suggestions. But unfortunately I'm not a computer programmer, so I can't make any changes myself. Some of the official lizzie contributors are good developers, so why not discuss it again? I think it will probably be more meaningful than the discussion here.

[Trevoke]

I think I've misunderstood something pretty critical. What is this repository?

[hope366]

This repository was created to borrow a pull request from the official lizzie and provide a more convenient lizzie to many people. I can apply a pull request to compile lizzie, but I can do almost nothing else. I'm sorry for the misunderstanding.

[Trevoke]

I'm a little confused, still. How did this repository get all those improvements over the base lizzie?

[hope366]

I prepared the source code of lizzie 0.7.3 locally and repeated the work of manually copying the contents of the pull request published in the official lizzie repository using Visual Studio Code.