hope-ui icon indicating copy to clipboard operation
hope-ui copied to clipboard

In dark mode, make scroll bar dark as well

Open berkaycimsir opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe. It would be nice if the colors of the scroll bar also change in dark mode. Currently, it feels weird to have white scroll bar in dark mode.

Describe the solution you'd like I am new to solid and hopeui so i didn't take a look to the source code yet. But seems like this library built with Stitches. So, i think there should be a base styles for light and dark mode.

For dark mode we can set colors of the scroll bar as dark colors by using css scroll-bar properties (https://www.w3schools.com/howto/howto_css_custom_scrollbar.asp)

Additional context Currently, it looks like this:

In light mode In dark mode
Screen Shot 2022-09-15 at 00 59 14 Screen Shot 2022-09-15 at 00 59 28

berkaycimsir avatar Sep 14 '22 22:09 berkaycimsir

It switches properly for light and dark modes for the website I'm building with hope-ui.

It also switches properly on the hope-ui website for me.

I'm using Firefox 105.0.1 on windows 10.

luckynumberke7in avatar Sep 29 '22 01:09 luckynumberke7in

Hi, the bug is fixed in hope-ui 1.0, like i said in the README v0.x will stay as is to focus on releasing 1.0.

v1.0 also has new features related to color mode like:

  • support for light, dark or system mode
  • automatic color mode switch when the OS mode changes (in system mode)
  • ability to disable animation when changing color mode, so it's "instant"

fabien-ml avatar Sep 29 '22 05:09 fabien-ml