grid icon indicating copy to clipboard operation
grid copied to clipboard

Why the id attribute in the grid item is required to be a Number?

Open rafaelmaiolla opened this issue 8 years ago • 2 comments

The following line: https://github.com/hootsuite/grid/blob/master/src/jquery.gridList.js#L201 transform the id to a number. Is there a reason for the id to be a number?

rafaelmaiolla avatar Mar 29 '16 20:03 rafaelmaiolla

Is there a reason for the id to be a number?

Can't think of one, probably just a legacy decision. If I'm not mistaken, id is just a generic assumption the lib has about your items, but it doesn't actually use it anywhere. @NiGhTTraX correct me if I'm wrong.

ovidiu-chereches-hs avatar Apr 06 '16 08:04 ovidiu-chereches-hs

@ovidiu-chereches-hs seems that way. At first I thought it was used inside the jQuery plugin to get the list of changed items, but it's using $element for that. Someone should remove it and see if anything breaks.

andrei-picus-hs avatar Apr 06 '16 16:04 andrei-picus-hs