influxdb-collectd-proxy
influxdb-collectd-proxy copied to clipboard
hoonmin
Added Dockerfile
Nice work. One comment.
The downside to this docker file is it includes the entire go tool chain, which defeats the point of using go which creates static binaries which have no dependencies. On Feb 15, 2015 1:32 PM, "Lorenz Brun" [email protected] wrote:
Added a Dockerfile for easy deployment
You can view, comment on, or merge this pull request online at:
https://github.com/hoonmin/influxdb-collectd-proxy/pull/27 Commit Summary
- Added Dockerfile
File Changes
- A Dockerfile https://github.com/hoonmin/influxdb-collectd-proxy/pull/27/files#diff-0 (9)
Patch Links:
- https://github.com/hoonmin/influxdb-collectd-proxy/pull/27.patch
- https://github.com/hoonmin/influxdb-collectd-proxy/pull/27.diff
— Reply to this email directly or view it on GitHub https://github.com/hoonmin/influxdb-collectd-proxy/pull/27.
Yes I know. I thought about it, but finally decided to go with a self-compiling dockerfile because the static binaries would have to be compiled outside of docker which means that autobuilds from the GitHub Repository aren't possible anymore. I could include a slim version which contains only precompiled images, but they would have to be compiled somewhere.
Maybe it's time to setup a Travis build someplace @hoonmin? On Feb 16, 2015 9:30 AM, "Lorenz Brun" [email protected] wrote:
Yes I know. I thought about it, but finally decided to go with a self-compiling dockerfile because the static binaries would have to be compiled outside of docker which means that autobuilds from the GitHub Repository aren't possible anymore. I could include a slim version which contains only precompiled images, but they would have to be compiled somewhere.
— Reply to this email directly or view it on GitHub https://github.com/hoonmin/influxdb-collectd-proxy/pull/27#issuecomment-74544143 .
A Travis Build would be an excellent solution, I would still keep two versions, a self-contained one (my current one) for people that fork the repo and want to do stuff quickly and a Travis version, which would precompile the binary and import it into a FROM scratch Dockerfile.
For the official Docker Image I would make the default tag for each version the slim build, and add a version-dev version for the large self-contained one.
What do you think of that?
SGTM On Feb 16, 2015 9:42 AM, "Lorenz Brun" [email protected] wrote:
A Travis Build would be an excellent solution, I would still keep two versions, a self-contained one (my current one) for people that fork the repo and want to do stuff quickly and a Travis version, which would precompile the binary and import it into a FROM scratch Dockerfile.
For the official Docker Image I would make the default tag for each version the slim build, and add a version-dev version for the large self-contained one.
What do you think of that?
— Reply to this email directly or view it on GitHub https://github.com/hoonmin/influxdb-collectd-proxy/pull/27#issuecomment-74546106 .
@lorenz Your dockerfile looks good but I think it would be better to export a VOLUME for types.db. And I prefer the base docker image(golang) you used because we have no binary release right now :-(
@yanfali Sure I agree with you. Please wait a sec :-)
