hoodie icon indicating copy to clipboard operation
hoodie copied to clipboard

npm deprecation warnings

Open mk-pmb opened this issue 7 years ago • 8 comments

You might want to upgrade these deps:

npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue npm WARN deprecated [email protected]: All versions below 4.0.1 of Nodemailer are deprecated. See https://nodemailer.com/status/

There may be more but I got bored watching the install so maybe I'll update the post once install finished.

mk-pmb avatar Jun 09 '17 23:06 mk-pmb

Thanks @mk-pmb!

It’s not as straight forward to update them. Some context

the minimatch seems to come from @hoodie/admin which we is a bit stale in its development, it’s also a sub sub sub sub sub dependency so I’m not sure how easy it will be to update for us

├─┬ @hoodie/[email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     ├─┬ [email protected]
│     │ └─┬ [email protected]
│     │   └── [email protected] 

we want to remove the nodemailer dependency altogether from @hoodie/account-server and have people implement things like email reset password flows themselves via plugins

└─┬ @hoodie/[email protected]
  └─┬ @hoodie/[email protected]
    └── [email protected]

we could probably update nodemailer to v4 in @hoodie/acount-server though as its a direct dependency

gr2m avatar Jun 10 '17 10:06 gr2m

npm install -g nodemailer

    // use this command 

digitalhemanth avatar Feb 27 '18 18:02 digitalhemanth

@digitalhemanth If installing a current version of the deprecated dependency globally turns off the deprecation warning on your node, I'd consider that a hint that your node might have problems with dependency resolution.

mk-pmb avatar Feb 27 '18 19:02 mk-pmb

Is this something I can work on?

dhuang612 avatar Nov 02 '19 19:11 dhuang612

Sure, feel free to :)

gr2m avatar Nov 02 '19 21:11 gr2m

created the following PR #891

dhuang612 avatar Nov 04 '19 23:11 dhuang612

I can start on the devDependencies next

dhuang612 avatar Nov 05 '19 19:11 dhuang612

created PR #892 for deprecation warnings under dev dependencies!

Thanks

dhuang612 avatar Nov 07 '19 19:11 dhuang612