nmap-bootstrap-xsl icon indicating copy to clipboard operation
nmap-bootstrap-xsl copied to clipboard

Darkmode

Open 0xspade opened this issue 4 years ago • 4 comments

Requesting Darkmode for this nmap bootstrap :)

0xspade avatar May 17 '20 07:05 0xspade

I was waiting for this! If you have any experience on how to add a dark mode in a graceful way, please let me know! :)

honze-net avatar May 18 '20 10:05 honze-net

Maybe this could help ? I'm not a developer, but I've stumbled upon this and it might do the trick.

3isenHeiM avatar Dec 10 '20 13:12 3isenHeiM

Thank you for the pull request to address this issue. During my analysis I ran into the same problem, that a dark mode in Bootstrap 3 is only possible with two matching themes. I could not find any vanilla dark theme. The themes you proposed have some rendering issues with too small font sizes in progress bars and the footer white space is too small. As of now I would not implement this PR, because it would decrease the readability of the report.

I suspect that there is no easy shortcut to achieve a clean dark mode in Bootstrap 3 other than using themes. Therefore I will look into theming and try to create a vanilla theme (should be easy) and a dark theme (only changed colors) for Bootstrap 3.

I will leave #14 open, because a solution is in sight. Thank you again for your work!

honze-net avatar Dec 24 '20 10:12 honze-net

looks like we need to revise the code back to zero if we need to implement the dark mode.

0xspade avatar Feb 18 '22 07:02 0xspade