Jan Špaček
Jan Špaček
So this means that we would have to scan the frontend code for the entity declarations? To be meaningful, we will also need a way to serialize and deserialize the...
This PR is now ready for review. Pekka and Jenda, may I ask both of you to do the review? This is a big change, so we need as many...
> @honzasp We use `pub(crate)` wherever possible _on purpose_ since day one because it allows us to detect unused code. Why are you switching over to `pub` everywhere? Dead code...
> @honzasp Why is the `endpoints` directory renamed to `routes` in the tests? Are users also expected to do that for their projects? Because the concept of an "endpoint" disappeared,...
> @honzasp The policy on copyright years is that we never update it on existing files. Oh, I'm an idiot, I should have checked this with you before changing this...
> @honzasp what's your rationale for changing the directory name? The rationale is that the concept of an "endpoint" does not exist anymore and the structure that is defined by...
Thanks Gustavo for your review, I applied your suggestions in the latest commit :) I left replies where I would like some clarifications, so we can continue the discussion in...
I reverted the new CRUD from this branch, the changes now live on another branch: https://github.com/honzasp/chiselstrike/pull/1
I think that I have addressed all issues brought up in review.
I squashed the commits into one and kept the original branch as `routing-unsquashed`.