middleware icon indicating copy to clipboard operation
middleware copied to clipboard

chore: update valibot dependency to v1

Open fabian-hiller opened this issue 1 year ago • 2 comments

I've updated the Valibot dependency of the adapter to v1. We've changed the type signature, so this change is necessary. All other changes in our v1 beta version are only internal.


An union of schema library authors (Zod, Valibot, ArkType, ...) collaborating on a standard interface for schema libraries called Standard Schema. This simplifies implementation and prevents vendor lock-in. So far Valibot v1 supports this spec and Zod will follow soon. In the long run, the explicit implementation of a Valibot and Zod adapter may no longer be necessary.

fabian-hiller avatar Oct 04 '24 16:10 fabian-hiller

🦋 Changeset detected

Latest commit: bf1d9bed705a3bc574e58441746bfa6ceda8c66e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/valibot-validator Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 04 '24 16:10 changeset-bot[bot]

Hi @fabian-hiller

Ah, Standard Schema seems to be great!

One thing I want you to do is to run the yarn changeset and push the changeset. This is a patch change. Thank you!

yusukebe avatar Oct 05 '24 03:10 yusukebe

Are you sure that this is a patch change? There will be TS errors if devs use Valibot v1 beta with the old adapter. I would release it as a 1.0.0-beta.0 or v0.4.0.

fabian-hiller avatar Oct 06 '24 05:10 fabian-hiller

@fabian-hiller

Ah, I see! Shall we go with v0.4.0 (minor version up)?

yusukebe avatar Oct 06 '24 07:10 yusukebe

Sounds good to me. We can bumb to v1 once v1 is out.

fabian-hiller avatar Oct 06 '24 15:10 fabian-hiller

@fabian-hiller

Thanks! Let's go!

yusukebe avatar Oct 07 '24 10:10 yusukebe